Messages in this thread | | | Subject | Re: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition | From | Rasmus Villemoes <> | Date | Tue, 15 Jun 2021 08:50:45 +0200 |
| |
On 15/06/2021 01.56, Punit Agrawal wrote: > Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while > improving readability by removing vprintk indirection, inadvertently > placed the EXPORT_SYMBOL() for the newly renamed function at the end > of the file. > > For reader sanity, and as is convention move the EXPORT_SYMBOL() > declaration just after the end of the function. > > Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") > Signed-off-by: Punit Agrawal <punitagrawal@gmail.com> > -- > Hi, > > The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while > attempting to rebase the RT patches onto newer kernels. > > Generally I avoid sending trivial changes on their own but this one is > a little hard to overlook. Also it felt like an obvious oversight in > the original patch.
Yes, indeed, sorry about that, and thanks for fixing it.
> Please consider merging.
Petr, as this is causing trouble for the -rt patchset, please consider if this could make it to Linus before v5.13 release.
Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Rasmus
| |