Messages in this thread | | | Date | Tue, 15 Jun 2021 15:51:53 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] PM: domains: call mutex_destroy when removing the genpd |
| |
On Fri, Jun 11, 2021 at 01:15:39PM +0300, Dmitry Baryshkov wrote: > It is a good practice to destroy mutexes with mutex_destroy, so call > this function for releasing genpd->mlock. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/base/power/domain.c | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index b6a782c31613..74219d032910 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1910,6 +1910,11 @@ static void genpd_lock_init(struct generic_pm_domain *genpd) > } > } > > +static void genpd_lock_destroy(struct generic_pm_domain *genpd) { > + if (!(genpd->flags & GENPD_FLAG_IRQ_SAFE)) > + mutex_destroy(&genpd->mlock); > +}
Did you run this through checkpatch.pl???
And what does mutex_destroy() do that is required here?
thanks,
greg k-h
| |