[lkml]   [2021]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC v2 33/34] mm, slub: use migrate_disable() on PREEMPT_RT
On 2021-06-14 13:07:14 [+0200], Vlastimil Babka wrote:
> > +#define slub_get_cpu_ptr(var) get_cpu_ptr(var)
> > +#define slub_put_cpu_ptr(var) put_cpu_ptr(var)
> After Mel's report and bisect pointing to this patch, I realized I got the
> #ifdef wrong and it should be #ifnded

So if you got the ifdef wrong (and kept everything as-is) then you
tested the RT version on !RT. migrate_disable() behaves on !RT as on RT.
As per changelog you don't use migrate_disable() unconditionally because
it increases the overhead on !RT.
I haven't looked at the series and I have just this tiny question: why
did migrate_disable() crash for Mel on !RT and why do you expect that it
does not happen on PREEMPT_RT?


 \ /
  Last update: 2021-06-14 13:34    [W:0.053 / U:2.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site