Messages in this thread | | | Date | Sat, 12 Jun 2021 17:23:49 -0700 (PDT) | Subject | Re: [PATCH] riscv: sifive: fix Kconfig errata warning | From | Palmer Dabbelt <> |
| |
On Sun, 06 Jun 2021 16:46:15 PDT (-0700), rdunlap@infradead.org wrote: > ping. anyone? > thanks.
Sorry, I missed the original patch. This is on fixes.
> > On 5/22/21 2:20 PM, Randy Dunlap wrote: >> The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE. >> However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is >> not set, so SOC_SIFIVE should either depend on or select >> RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig >> warning. >> >> WARNING: unmet direct dependencies detected for ERRATA_SIFIVE >> Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n] >> Selected by [y]: >> - SOC_SIFIVE [=y] >> >> Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Paul Walmsley <paul.walmsley@sifive.com> >> Cc: Palmer Dabbelt <palmer@dabbelt.com> >> Cc: Albert Ou <aou@eecs.berkeley.edu> >> Cc: linux-riscv@lists.infradead.org >> Cc: Vincent Chen <vincent.chen@sifive.com> >> --- >> arch/riscv/Kconfig.socs | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20210521.orig/arch/riscv/Kconfig.socs >> +++ linux-next-20210521/arch/riscv/Kconfig.socs >> @@ -14,6 +14,7 @@ config SOC_SIFIVE >> select CLK_SIFIVE >> select CLK_SIFIVE_PRCI >> select SIFIVE_PLIC >> + select RISCV_ERRATA_ALTERNATIVE >> select ERRATA_SIFIVE >> help >> This enables support for SiFive SoC platform hardware. >>
| |