Messages in this thread Patch in this message | | | From | Yang Yingliang <> | Subject | [PATCH -next 9/9] ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname() | Date | Fri, 11 Jun 2021 17:36:26 +0800 |
| |
It will cause null-ptr-deref if platform_get_resource_byname() returns NULL, we need check the return value.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- sound/soc/fsl/fsl_xcvr.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index df7c189d97dd..2e9061c5ed74 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -1202,6 +1202,10 @@ static int fsl_xcvr_probe(struct platform_device *pdev) rx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rxfifo"); tx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "txfifo"); + if (!rx_res || !tx_res) { + dev_err(dev, "Invalid resource\n"); + return -EINVAL; + } xcvr->dma_prms_rx.chan_name = "rx"; xcvr->dma_prms_tx.chan_name = "tx"; xcvr->dma_prms_rx.addr = rx_res->start; -- 2.25.1
| |