lkml.org 
[lkml]   [2021]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v2] net: mdio: mscc-miim: Use devm_platform_get_and_ioremap_resource()
From
Date

> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
> only convert the first platform_get_resource()
> ---
> drivers/net/mdio/mdio-mscc-miim.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
> index b36e5ea04ddf..071c654bab29 100644
> --- a/drivers/net/mdio/mdio-mscc-miim.c
> +++ b/drivers/net/mdio/mdio-mscc-miim.c
> @@ -139,10 +139,6 @@ static int mscc_miim_probe(struct platform_device *pdev)
> struct mscc_miim_dev *dev;
> int ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -ENODEV;
> -
> bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev));
> if (!bus)
> return -ENOMEM;
> @@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device *pdev)
> bus->parent = &pdev->dev;
>
> dev = bus->priv;
> - dev->regs = devm_ioremap_resource(&pdev->dev, res);
> + dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);


res not used later, so should be

dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);


> if (IS_ERR(dev->regs)) {
> dev_err(&pdev->dev, "Unable to map MIIM registers\n");
> return PTR_ERR(dev->regs);

\
 
 \ /
  Last update: 2021-06-11 08:59    [W:0.063 / U:1.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site