lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v9 03/22] media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL
    Hi Ricardo,

    Thank you for the patch.

    On Fri, Mar 26, 2021 at 10:58:21AM +0100, Ricardo Ribalda wrote:
    > The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is
    > written.
    >
    > Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > drivers/media/usb/uvc/uvc_v4l2.c | 4 ----
    > 1 file changed, 4 deletions(-)
    >
    > diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
    > index 252136cc885c..47b0e3224205 100644
    > --- a/drivers/media/usb/uvc/uvc_v4l2.c
    > +++ b/drivers/media/usb/uvc/uvc_v4l2.c
    > @@ -1089,10 +1089,6 @@ static int uvc_ioctl_s_try_ext_ctrls(struct uvc_fh *handle,
    > unsigned int i;
    > int ret;
    >
    > - /* Default value cannot be changed */
    > - if (ctrls->which == V4L2_CTRL_WHICH_DEF_VAL)
    > - return -EINVAL;
    > -
    > ret = uvc_ctrl_begin(chain);
    > if (ret < 0)
    > return ret;

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2021-06-10 18:22    [W:4.133 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site