lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property
Hi Rob, Krzysztof,

Rob Herring <robh@kernel.org> wrote on Thu, 10 Jun 2021 10:53:45 -0500:

> On Thu, Jun 10, 2021 at 10:20:30AM +0200, Miquel Raynal wrote:
> > The SMC bus controller features several register sets. The one pointed
> > by the reg property is for the SMC configuration (impacts the
> > sub-controllers configuration), while the others are meant to be used to
> > send regular cycles on the memory bus (eg. CMD, ADDR, DATA for a NAND
> > device). Detail this a little bit for the sake of clarity.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > .../devicetree/bindings/memory-controllers/pl353-smc.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> > index ecd46856f139..ba6a5426f62b 100644
> > --- a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> > +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> > @@ -5,7 +5,8 @@ of memory interfaces: NAND and memory mapped interfaces (such as SRAM or NOR).
> >
> > Required properties:
> > - compatible : Should be "arm,pl353-smc-r2p1", "arm,primecell".
> > -- reg : Controller registers map and length.
> > +- reg : SMC controller and sub-controllers configuration
> > + registers.
>
> I think you could just drop this patch. Otherwise, this doesn't match
> what's now in the yaml file.

Fine.

Krzysztof, if it's still time you can just take patch 9 which Rob
just acked and forget about this one. I think we'll be good. Otherwise
that will be for the next MW ;)

Thanks,
Miquèl

\
 
 \ /
  Last update: 2021-06-10 18:02    [W:0.083 / U:4.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site