lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nfc: fdp: remove unnecessary labels
From
Date
On 10/06/2021 04:46, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
>
> Some labels are meaningless, so we delete them and use the
> return statement instead of the goto statement.
>
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> ---
> drivers/nfc/fdp/fdp.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof

> diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c
> index 7863b25..5287458 100644
> --- a/drivers/nfc/fdp/fdp.c
> +++ b/drivers/nfc/fdp/fdp.c
> @@ -266,7 +266,7 @@ static int fdp_nci_request_firmware(struct nci_dev *ndev)
> r = request_firmware(&info->ram_patch, FDP_RAM_PATCH_NAME, dev);
> if (r < 0) {
> nfc_err(dev, "RAM patch request error\n");
> - goto error;
> + return r;
> }
>
> data = (u8 *) info->ram_patch->data;
> @@ -283,7 +283,7 @@ static int fdp_nci_request_firmware(struct nci_dev *ndev)
> r = request_firmware(&info->otp_patch, FDP_OTP_PATCH_NAME, dev);
> if (r < 0) {
> nfc_err(dev, "OTP patch request error\n");
> - goto out;
> + return 0;
> }
>
> data = (u8 *) info->otp_patch->data;
> @@ -295,10 +295,7 @@ static int fdp_nci_request_firmware(struct nci_dev *ndev)
>
> dev_dbg(dev, "OTP patch version: %d, size: %d\n",
> info->otp_patch_version, (int) info->otp_patch->size);
> -out:
> return 0;
> -error:
> - return r;
> }
>
> static void fdp_nci_release_firmware(struct nci_dev *ndev)
>

\
 
 \ /
  Last update: 2021-06-10 08:37    [W:0.786 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site