Messages in this thread | | | Subject | Re: [PATCH v5 7/7] KVM: SVM: hyper-v: Direct Virtual Flush support | From | Paolo Bonzini <> | Date | Thu, 10 Jun 2021 17:16:55 +0200 |
| |
On 10/06/21 13:16, Vitaly Kuznetsov wrote: >> +int hv_enable_direct_tlbflush(struct kvm_vcpu *vcpu) >> +{ > I would've avoided re-using 'hv_enable_direct_tlbflush()' name which we > already have in vmx. In fact, in the spirit of this patch, I'd suggest > we create arch/x86/kvm/vmx/vmx_onhyperv.c and move the existing > hv_enable_direct_tlbflush() there. We can then re-name it to e.g. > > vmx_enable_hv_direct_tlbflush() > > so the one introduced by this patch will be > > svm_enable_hv_direct_tlbflush() >
I did the rename, and agree with creating a similar file that is split off vmx.c.
Paolo
| |