lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c
From
Date


On 6/9/21 2:23 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in qla_target.c.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> V1->V2:
> CC mailist
>
> drivers/scsi/qla2xxx/qla_target.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 12a6848ade43..eb47140a899f 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -5481,8 +5481,7 @@ qlt_free_qfull_cmds(struct qla_qpair *qpair)
> "%s: Unexpected cmd in QFull list %p\n", __func__,
> cmd);
>
> - list_del(&cmd->cmd_list);
> - list_add_tail(&cmd->cmd_list, &free_list);
> + list_move_tail(&cmd->cmd_list, &free_list);
>
> /* piggy back on hardware_lock for protection */
> vha->hw->tgt.num_qfull_cmds_alloc--;
>

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani Oracle Linux Engineering

\
 
 \ /
  Last update: 2021-06-10 16:34    [W:0.092 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site