Messages in this thread | | | Date | Thu, 10 Jun 2021 14:26:36 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v2 04/12] ASoC: hdmi-codec: Add iec958 controls |
| |
Hi Mark
On Wed, Jun 09, 2021 at 01:43:04PM +0100, Mark Brown wrote: > On Tue, May 25, 2021 at 03:23:46PM +0200, Maxime Ripard wrote: > > The IEC958 status bits can be exposed and modified by the userspace > > through dedicated ALSA controls. > > > > This patch implements those controls for the hdmi-codec driver. It > > relies on a default value being setup at probe time that can later be > > overridden by the control put. > > This breaks bisection: > > /mnt/kernel/sound/soc/codecs/hdmi-codec.c: In function 'hdmi_codec_hw_params': > /mnt/kernel/sound/soc/codecs/hdmi-codec.c:504:50: error: invalid type argument of '->' (have 'struct hdmi_codec_params') > memcpy(hp.iec.status, hcp->iec_status, sizeof(hp->iec_status)); > ^~
Indeed, sorry. I just sent a new version of the PR with that breakage fixed
Maxime [unhandled content-type:application/pgp-signature] | |