Messages in this thread | | | From | hongbo li <> | Date | Tue, 1 Jun 2021 21:04:35 +0800 | Subject | Re: [PATCH] crypto: sm2 - fix a memory leak in sm2 |
| |
Hi Tianjia,
Tianjia Zhang <tianjia.zhang@linux.alibaba.com> 于2021年6月1日周二 上午10:54写道: > > Hi Hongbo, > > On 5/31/21 9:30 PM, Hongbo Li wrote: > > From: Hongbo Li <herberthbli@tencent.com> > > > > SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in > > test_akcipher_one(), it will set public key for every test vector, > > and don't free ec->Q. This will cause a memory leak. > > > > This patch alloc ec->Q in sm2_ec_ctx_init(). > > > > Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm") > > Signed-off-by: Hongbo Li <herberthbli@tencent.com> > > Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> > > --- > > crypto/sm2.c | 24 ++++++++++-------------- > > 1 file changed, 10 insertions(+), 14 deletions(-) > > > > Just add Cc: to SOB, like this: > > Fixes: ea7ecb66440b (...) > Signed-off-by: Hongbo Li <herberthbli@tencent.com> > Cc: stable@vger.kernel.org # v5.10+ > Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> > > Thanks, > Tianjia
Thank you, I will resend the patch. Hongbo
| |