Messages in this thread | | | Date | Tue, 1 Jun 2021 13:28:40 +0300 | From | Eli Cohen <> | Subject | Re: [PATCH] vdpa: fix error return in vp_vdpa_probe() |
| |
On Tue, Jun 01, 2021 at 04:05:05PM +0800, Jing Xiangfeng wrote: > Fix to return error code '-ENOMEM' from the error handling case instead > of 0. > > Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()") > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Eli Cohen <elic@nvidia.com>
> --- > drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c > index c76ebb531212..e5d92db728d3 100644 > --- a/drivers/vdpa/virtio_pci/vp_vdpa.c > +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c > @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id) > vp_modern_map_vq_notify(mdev, i, > &vp_vdpa->vring[i].notify_pa); > if (!vp_vdpa->vring[i].notify) { > + ret = -ENOMEM; > dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i); > goto err; > } > -- > 2.26.0.106.g9fadedd >
| |