lkml.org 
[lkml]   [2021]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mm: make "vm_flags" be an u64
Hi Ming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on arm64/for-next/core powerpc/next asm-generic/master linus/master v5.13-rc4]
[cannot apply to hnaz-linux-mm/master tip/x86/core next-20210601]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Ming-Lin/mm-adds-MAP_NOSIGBUS-extension-for-shmem-read/20210602-072403
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47
config: s390-randconfig-r011-20210601 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/0b6b8b44f566199698248899d0fef7466ba6b0f3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ming-Lin/mm-adds-MAP_NOSIGBUS-extension-for-shmem-read/20210602-072403
git checkout 0b6b8b44f566199698248899d0fef7466ba6b0f3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

arch/s390/mm/gmap.c: In function 'gmap_mark_unmergeable':
>> arch/s390/mm/gmap.c:2577:25: error: passing argument 5 of 'ksm_madvise' from incompatible pointer type [-Werror=incompatible-pointer-types]
2577 | MADV_UNMERGEABLE, &vma->vm_flags);
| ^~~~~~~~~~~~~~
| |
| vm_flags_t * {aka long long unsigned int *}
In file included from arch/s390/mm/gmap.c:18:
include/linux/ksm.h:70:49: note: expected 'long unsigned int *' but argument is of type 'vm_flags_t *' {aka 'long long unsigned int *'}
70 | unsigned long end, int advice, unsigned long *vm_flags)
| ~~~~~~~~~~~~~~~^~~~~~~~
cc1: some warnings being treated as errors


vim +/ksm_madvise +2577 arch/s390/mm/gmap.c

1e133ab296f3ff Martin Schwidefsky 2016-03-08 2568
fa0c5eabbdd330 Janosch Frank 2019-07-16 2569 int gmap_mark_unmergeable(void)
fa0c5eabbdd330 Janosch Frank 2019-07-16 2570 {
fa0c5eabbdd330 Janosch Frank 2019-07-16 2571 struct mm_struct *mm = current->mm;
fa0c5eabbdd330 Janosch Frank 2019-07-16 2572 struct vm_area_struct *vma;
7a2653612bb6f1 Christian Borntraeger 2020-03-27 2573 int ret;
fa0c5eabbdd330 Janosch Frank 2019-07-16 2574
fa0c5eabbdd330 Janosch Frank 2019-07-16 2575 for (vma = mm->mmap; vma; vma = vma->vm_next) {
7a2653612bb6f1 Christian Borntraeger 2020-03-27 2576 ret = ksm_madvise(vma, vma->vm_start, vma->vm_end,
7a2653612bb6f1 Christian Borntraeger 2020-03-27 @2577 MADV_UNMERGEABLE, &vma->vm_flags);
7a2653612bb6f1 Christian Borntraeger 2020-03-27 2578 if (ret)
7a2653612bb6f1 Christian Borntraeger 2020-03-27 2579 return ret;
fa0c5eabbdd330 Janosch Frank 2019-07-16 2580 }
fa0c5eabbdd330 Janosch Frank 2019-07-16 2581 mm->def_flags &= ~VM_MERGEABLE;
fa0c5eabbdd330 Janosch Frank 2019-07-16 2582 return 0;
fa0c5eabbdd330 Janosch Frank 2019-07-16 2583 }
fa0c5eabbdd330 Janosch Frank 2019-07-16 2584 EXPORT_SYMBOL_GPL(gmap_mark_unmergeable);
fa0c5eabbdd330 Janosch Frank 2019-07-16 2585

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-06-02 04:08    [W:1.587 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site