| Date | Fri, 07 May 2021 10:16:11 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH 13/42] PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts |
| |
On Thu, 06 May 2021 16:31:24 +0100, Pali Rohár <pali@kernel.org> wrote: > > Callback for irq_mask_ack is the same as for irq_mask. As there is no > special handling for irq_ack, there is no need to define irq_mask_ack too. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Reviewed-by: Marek Behún <kabel@kernel.org> > --- > drivers/pci/controller/pci-aardvark.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > index e7089db11f79..2aced8c9ae9f 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -1032,7 +1032,6 @@ static int advk_pcie_init_irq_domain(struct advk_pcie *pcie) > } > > irq_chip->irq_mask = advk_pcie_irq_mask; > - irq_chip->irq_mask_ack = advk_pcie_irq_mask; > irq_chip->irq_unmask = advk_pcie_irq_unmask; > > pcie->irq_domain =
Acked-by: Marc Zyngier <maz@kernel.org>
M.
-- Without deviation from the norm, progress is not possible.
|