lkml.org 
[lkml]   [2021]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] iio: bme680_i2c: Make bme680_acpi_match depend on CONFIG_ACPI
On Tue, May 4, 2021 at 8:40 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> With CONFIG_ACPI=n and -Werror, 0-day reports:
>
> drivers/iio/chemical/bme680_i2c.c:46:36: error:
> 'bme680_acpi_match' defined but not used

> Given the other patch, question of course is if this ACPI ID
> is real. A Google search suggests that this might not be the case.
> Should we remove it as well ? STK8312 has the same problem.

For this one definitely removal. Looking into the code it suggests a
cargo cult taken that time by a few contributors to invent fake ACPI
IDs while submitting new drivers.
Feel free to add my tag or if you wish me I'll add it explicitly.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-05-04 19:45    [W:0.052 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site