lkml.org 
[lkml]   [2021]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/3] memory: Add support for MediaTek External Memory Interface driver
From
Date
On 27/01/2021 07:28, EastL Lee wrote:
> MediaTek External Memory Interface(emi) on MT6779 SoC controls all the
> transitions from master to dram, there are emi-cen & emi-mpu drivers.
>
> emi-cen driver provides phy addr to dram rank, bank, column and other
> information, as well as the currently used dram channel number, rank
> number, rank size.
>
> emi-mpu (memory protect unit) driver provides an interface to set emi
> regions, need to enter the secure world setting and the violation irq
> isr will collect mpu violation information, after all regions have
> protected their respective regions, emi-mpu will set the ap region to
> protect all the remaining dram.
>
> Signed-off-by: EastL Lee <EastL.Lee@mediatek.com>
> ---
> drivers/memory/Kconfig | 1 +
> drivers/memory/Makefile | 1 +
> drivers/memory/mediatek/Kconfig | 23 +
> drivers/memory/mediatek/Makefile | 4 +
> drivers/memory/mediatek/emi-cen.c | 1305 ++++++++++++++++++++++++++++++
> drivers/memory/mediatek/emi-mpu.c | 908 +++++++++++++++++++++
> include/linux/soc/mediatek/mtk_sip_svc.h | 3 +
> include/soc/mediatek/emi.h | 101 +++
> 8 files changed, 2346 insertions(+)
> create mode 100644 drivers/memory/mediatek/Kconfig
> create mode 100644 drivers/memory/mediatek/Makefile
> create mode 100644 drivers/memory/mediatek/emi-cen.c
> create mode 100644 drivers/memory/mediatek/emi-mpu.c
> create mode 100644 include/soc/mediatek/emi.h
>

Use scripts/get_maintainers.pl to get list of people you need to Cc.

Run checkpatch, smatch, sparse and coccinelle on your new driver. I can
easily see that some of these steps were missing (e.g. OWNER field...).

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-05-04 16:18    [W:0.065 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site