lkml.org 
[lkml]   [2021]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] dt-bindings: mediatek: Add optional mediatek, gce-events property
From
Date
Hi, Hsin-yi:

On Mon, 2021-05-03 at 13:05 +0800, Hsin-Yi Wang wrote:
> mediatek,gce-events property is used by gce clients.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index fbb59c9ddda6..939b2da3bdc5 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -75,6 +75,10 @@ Optional properties (RDMA function blocks):
> mediatek,rdma-fifo-size of mt8183-rdma0 is 5K
> mediatek,rdma-fifo-size of mt8183-rdma1 is 2K
>
> +Optional properties for display mutex:
> +- mediatek,gce-events: GCE events used by clients. The event numbers are
> + defined in 'dt-bindings/gce/<chip>-gce.h'.

I think mediatek,gce-events should be first defined in [1], and here
refer to [1].

In addition, mtk-mutex driver is moved into soc folder, so I would like
to move mtk-mutex binding out of display binding. It's up to you.

[1] Documentation/devicetree/bindings/mailbox/mtk-gce.txt

Regards,
CK

> +
> Examples:
>
> mmsys: clock-controller@14000000 {
> @@ -209,6 +213,8 @@ mutex: mutex@14020000 {
> interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
> power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> clocks = <&mmsys CLK_MM_MUTEX_32K>;
> + mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
> + <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
> };
>
> od@14023000 {

\
 
 \ /
  Last update: 2021-05-04 06:11    [W:0.088 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site