Messages in this thread | | | Date | Tue, 4 May 2021 15:32:02 +0200 | From | Greg KH <> | Subject | Re: [PATCH 2/3] staging: rtl8723bs: use in-kernel aes encryption in OMAC1 routines |
| |
On Tue, May 04, 2021 at 03:12:56PM +0200, Fabio Aiuto wrote: > --- a/drivers/staging/rtl8723bs/include/rtw_security.h > +++ b/drivers/staging/rtl8723bs/include/rtw_security.h > @@ -7,6 +7,7 @@ > #ifndef __RTW_SECURITY_H_ > #define __RTW_SECURITY_H_ > > +#include <crypto/aes.h>
Why put this .h in a .h file? Why not just put it in the .c file(s) that need it?
You will note that this .h file does not have any other #include lines in it...
thanks,
greg k-h
| |