Messages in this thread Patch in this message | | | From | Khaled ROMDHANI <> | Subject | [PATCH-next] fs/cifs: Fix resource leak | Date | Tue, 4 May 2021 13:43:43 +0100 |
| |
The -EIO error return path is leaking memory allocated to page. Fix this by invoking the free_dentry_path before the return.
Addresses-Coverity: ("Resource leak") Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com> --- fs/cifs/link.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/cifs/link.c b/fs/cifs/link.c index 1cbe7ec73728..1485c6095ba1 100644 --- a/fs/cifs/link.c +++ b/fs/cifs/link.c @@ -686,8 +686,10 @@ cifs_symlink(struct user_namespace *mnt_userns, struct inode *inode, void *page = alloc_dentry_path(); struct inode *newinode = NULL; - if (unlikely(cifs_forced_shutdown(cifs_sb))) + if (unlikely(cifs_forced_shutdown(cifs_sb))) { + free_dentry_path(page); return -EIO; + } xid = get_xid(); -- 2.17.1
| |