lkml.org 
[lkml]   [2021]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 092/116] SMB3: incorrect file id in requests compounded with open
    Date
    From: Steve French <stfrench@microsoft.com>

    [ Upstream commit c0d46717b95735b0eacfddbcca9df37a49de9c7a ]

    See MS-SMB2 3.2.4.1.4, file ids in compounded requests should be set to
    0xFFFFFFFFFFFFFFFF (we were treating it as u32 not u64 and setting
    it incorrectly).

    Signed-off-by: Steve French <stfrench@microsoft.com>
    Reported-by: Stefan Metzmacher <metze@samba.org>
    Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/cifs/smb2pdu.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
    index 07d1c79a79ea..43478ec6fd67 100644
    --- a/fs/cifs/smb2pdu.c
    +++ b/fs/cifs/smb2pdu.c
    @@ -3124,10 +3124,10 @@ smb2_new_read_req(void **buf, unsigned int *total_len,
    * Related requests use info from previous read request
    * in chain.
    */
    - shdr->SessionId = 0xFFFFFFFF;
    + shdr->SessionId = 0xFFFFFFFFFFFFFFFF;
    shdr->TreeId = 0xFFFFFFFF;
    - req->PersistentFileId = 0xFFFFFFFF;
    - req->VolatileFileId = 0xFFFFFFFF;
    + req->PersistentFileId = 0xFFFFFFFFFFFFFFFF;
    + req->VolatileFileId = 0xFFFFFFFFFFFFFFFF;
    }
    }
    if (remaining_bytes > io_parms->length)
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-31 15:50    [W:6.338 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site