lkml.org 
[lkml]   [2021]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 027/116] staging: iio: cdc: ad7746: avoid overwrite of num_channels
    Date
    From: Lucas Stankus <lucas.p.stankus@gmail.com>

    commit 04f5b9f539ce314f758d919a14dc7a669f3b7838 upstream.

    AD7745 devices don't have the CIN2 pins and therefore can't handle related
    channels. Forcing the number of AD7746 channels may lead to enabling more
    channels than what the hardware actually supports.
    Avoid num_channels being overwritten after first assignment.

    Signed-off-by: Lucas Stankus <lucas.p.stankus@gmail.com>
    Fixes: 83e416f458d53 ("staging: iio: adc: Replace, rewrite ad7745 from scratch.")
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/iio/cdc/ad7746.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/staging/iio/cdc/ad7746.c
    +++ b/drivers/staging/iio/cdc/ad7746.c
    @@ -703,7 +703,6 @@ static int ad7746_probe(struct i2c_clien
    indio_dev->num_channels = ARRAY_SIZE(ad7746_channels);
    else
    indio_dev->num_channels = ARRAY_SIZE(ad7746_channels) - 2;
    - indio_dev->num_channels = ARRAY_SIZE(ad7746_channels);
    indio_dev->modes = INDIO_DIRECT_MODE;

    if (pdata) {

    \
     
     \ /
      Last update: 2021-05-31 15:40    [W:2.348 / U:0.772 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site