lkml.org 
[lkml]   [2021]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: ipq8074: disable USB phy by default
On 2021-05-26 20:31, Robert Marko wrote:
> One of the QUSB USB PHY-s has been left enabled by
> default, this is probably just a mistake as other
> USB PHY-s are disabled by default.
>
> It makes no sense to have it enabled by default as
> not all board implement USB ports, so disable it.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Always, it is better to disable in SOC DTS and enable only in the board
DTS files.

Reviewed-by: Kathiravan T <kathirav@codeaurora.org>

> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 555a107959831..20059d0f7d714 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -286,6 +286,7 @@ qusb_phy_0: phy@79000 {
> clock-names = "cfg_ahb", "ref";
>
> resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> + status = "disabled";
> };
>
> qmp_pcie_phy0: phy@84000 {

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation

\
 
 \ /
  Last update: 2021-05-31 14:12    [W:0.045 / U:1.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site