lkml.org 
[lkml]   [2021]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/10] i2c: xiic: Fix coding style issues
From
Date
On Mon, 2021-05-31 at 07:19 -0600, Raviteja Narayanam wrote:
> From: Michal Simek <michal.simek@xilinx.com>
>
> Most of these stuff are reported by checkpatch.

trivia:

> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
[]
> @@ -519,8 +522,8 @@ static irqreturn_t xiic_process(int irq, void *dev_id)
>  
>
>   /* Service requesting interrupt */
>   if ((pend & XIIC_INTR_ARB_LOST_MASK) ||
> - ((pend & XIIC_INTR_TX_ERROR_MASK) &&
> - !(pend & XIIC_INTR_RX_FULL_MASK))) {
> + ((pend & XIIC_INTR_TX_ERROR_MASK) &&
> + !(pend & XIIC_INTR_RX_FULL_MASK))) {

This last line would more commonly be indented one more space to
align to the appropriate open parenthesis depth.

tab then 4 spaces for
((pend & XIIC_INTR_TX_ERROR_MASK) &&
tab then 5 spaces for
!(pend & XIIC_INTR_RX_FULL_MASK))) {



\
 
 \ /
  Last update: 2021-05-31 19:02    [W:0.114 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site