lkml.org 
[lkml]   [2021]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 05/24] media: gspca/sq905.c: fix uninitialized variable
    Date
    From: Hans Verkuil <hverkuil-cisco@xs4all.nl>

    [ Upstream commit eaaea4681984c79d2b2b160387b297477f0c1aab ]

    act_len can be uninitialized if usb_bulk_msg() returns an error.
    Set it to 0 to avoid a KMSAN error.

    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Reported-by: syzbot+a4e309017a5f3a24c7b3@syzkaller.appspotmail.com
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/usb/gspca/sq905.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/usb/gspca/sq905.c b/drivers/media/usb/gspca/sq905.c
    index a7ae0ec9fa91..03322d2b2e82 100644
    --- a/drivers/media/usb/gspca/sq905.c
    +++ b/drivers/media/usb/gspca/sq905.c
    @@ -172,7 +172,7 @@ static int
    sq905_read_data(struct gspca_dev *gspca_dev, u8 *data, int size, int need_lock)
    {
    int ret;
    - int act_len;
    + int act_len = 0;

    gspca_dev->usb_buf[0] = '\0';
    if (need_lock)
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-05-03 19:10    [W:3.552 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site