lkml.org 
[lkml]   [2021]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 042/100] mmc: sdhci-esdhc-imx: validate pinctrl before use it
    Date
    From: Peng Fan <peng.fan@nxp.com>

    [ Upstream commit f410ee0aa2df050a9505f5c261953e9b18e21206 ]

    When imx_data->pinctrl is not a valid pointer, pinctrl_lookup_state
    will trigger kernel panic.

    When we boot Dual OS on Jailhouse hypervisor, we let the 1st Linux to
    configure pinmux ready for the 2nd OS, so the 2nd OS not have pinctrl
    settings.

    Similar to this commit b62eee9f804e ("mmc: sdhci-esdhc-imx: no fail when no pinctrl available").

    Reviewed-by: Bough Chen <haobo.chen@nxp.com>
    Reviewed-by: Alice Guo <alice.guo@nxp.com>
    Signed-off-by: Peng Fan <peng.fan@nxp.com>
    Link: https://lore.kernel.org/r/1614222604-27066-6-git-send-email-peng.fan@oss.nxp.com
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/sdhci-esdhc-imx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
    index 5d9b3106d2f7..d28809e47962 100644
    --- a/drivers/mmc/host/sdhci-esdhc-imx.c
    +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
    @@ -1504,7 +1504,7 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev,

    mmc_of_parse_voltage(np, &host->ocr_mask);

    - if (esdhc_is_usdhc(imx_data)) {
    + if (esdhc_is_usdhc(imx_data) && !IS_ERR(imx_data->pinctrl)) {
    imx_data->pins_100mhz = pinctrl_lookup_state(imx_data->pinctrl,
    ESDHC_PINCTRL_STATE_100MHZ);
    imx_data->pins_200mhz = pinctrl_lookup_state(imx_data->pinctrl,
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-05-03 19:09    [W:4.268 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site