lkml.org 
[lkml]   [2021]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 03/31] scsi: target: pscsi: Fix warning in pscsi_complete_cmd()
    Date
    From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

    [ Upstream commit fd48c056a32ed6e7754c7c475490f3bed54ed378 ]

    This fixes a compilation warning in pscsi_complete_cmd():

    drivers/target/target_core_pscsi.c: In function ‘pscsi_complete_cmd’:
    drivers/target/target_core_pscsi.c:624:5: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */

    Link: https://lore.kernel.org/r/20210228055645.22253-5-chaitanya.kulkarni@wdc.com
    Reviewed-by: Mike Christie <michael.christie@oracle.com>
    Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
    Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/target/target_core_pscsi.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
    index f80b31b35a0d..a127608a4809 100644
    --- a/drivers/target/target_core_pscsi.c
    +++ b/drivers/target/target_core_pscsi.c
    @@ -633,8 +633,9 @@ static void pscsi_complete_cmd(struct se_cmd *cmd, u8 scsi_status,
    unsigned char *buf;

    buf = transport_kmap_data_sg(cmd);
    - if (!buf)
    + if (!buf) {
    ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */
    + }

    if (cdb[0] == MODE_SENSE_10) {
    if (!(buf[3] & 0x80))
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-05-03 19:02    [W:3.604 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site