lkml.org 
[lkml]   [2021]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion
On Mon, May 03, 2021 at 10:27:11AM +0300, Dan Carpenter wrote:
> On Fri, Apr 30, 2021 at 04:56:24PM +0200, Fabio Aiuto wrote:
> > @@ -1533,13 +1529,10 @@ static void phy_IQCalibrate_8723B(
> > result[t][6] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> > result[t][7] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> > break;
> > - } else {
> > }
> > }
> >
> > /* Allen end */
>
> This comment doesn't mean anything. It feels like it was supposed to
> go with the code that you deleted so it should have been deleted as part
> of deleting the empty block. But it's fine to me if you delete it in
> a later patch.

Hi Dan,

ok I will.

>
> > - if (0x00 == PathBOK) {
> > - }
> > }
> >
> > /* Back to BB mode, load original value */
>
> regards,
> dan carpenter
>

thank you,

fabio

\
 
 \ /
  Last update: 2021-05-03 09:44    [W:0.071 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site