Messages in this thread | | | Date | Mon, 3 May 2021 22:38:42 +0200 | From | Heiko Carstens <> | Subject | Re: [PATCH] s390: fix detection of vector enhancements facility 1 vs. vector packed decimal facility |
| |
On Mon, May 03, 2021 at 02:12:44PM +0200, David Hildenbrand wrote: > The PoP documents: > 134: The vector packed decimal facility is installed in the > z/Architecture architectural mode. When bit 134 is > one, bit 129 is also one. > 135: The vector enhancements facility 1 is installed in > the z/Architecture architectural mode. When bit 135 > is one, bit 129 is also one. > > Looks like we confuse the vector enhancements facility 1 ("EXT") with the > Vector packed decimal facility ("BCD"). Let's fix the facility checks. > > Detected while working on QEMU/tcg z14 support and only unlocking > the vector enhancements facility 1, but not the vector packed decimal > facility. > > Fixes: 2583b848cad0 ("s390: report new vector facilities") > Cc: Heiko Carstens <hca@linux.ibm.com> > Cc: Vasily Gorbik <gor@linux.ibm.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: Sven Schnelle <svens@linux.ibm.com> > Cc: Alexander Egorenkov <egorenar@linux.ibm.com> > Cc: Niklas Schnelle <schnelle@linux.ibm.com> > Cc: Janosch Frank <frankja@linux.ibm.com> > Cc: linux-s390@vger.kernel.org > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > arch/s390/kernel/setup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks!
| |