lkml.org 
[lkml]   [2021]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] x86/apic: Fix BUG due to multiple allocation of legacy vectors.
From
Date
Hi Thomas,

On 26/5/21 12:51 am, Thomas Gleixner wrote:
> Imran,
>
> On Mon, May 24 2021 at 13:29, imran f. khan wrote:
[...]
>
>> Even my current setup that was crashing with in-house 5.4 and 5.8
>> kernels, boots fine if I boot it with noapic option removed from kernel
>> boot parameters.
>
> May I ask the obvious question why the changelog of your patch did not
> mention that this happens only with 'noapic' on the kernel command line?
>
I was not aware of it earlier. After your first feedback I debugged the
code further with ML tag and found out about the noapic dependency.
[...]
>
> Correct. So you almost decoded the underlying problem.
>
[...]
> So the right thing to do is to ensure that the legacy interrupts are
> marked as system vectors in case that the IO/APIC is disabled via
> config, kernel command line or lack of enumeration. See below.
>
Thanks for clarifying it. I have tested your change in my local setup as
well and it works well.

Thanks,
Imran

\
 
 \ /
  Last update: 2021-05-27 07:15    [W:0.044 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site