Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 26 May 2021 06:20:35 -1000 | Subject | Re: [GIT PULL] mtd: Changes for v5.13-rc4 |
| |
On Wed, May 26, 2021 at 5:59 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Raw NAND: > * txx9ndfmc, tmio, sharpsl, ndfc, lpc32xx_slc, fsmc, cs553x: > - Fix external use of SW Hamming ECC helper
Why are these guys all pointlessly duplicating the ecc wrapper functions for their ecc 'correct' functions?
The whole "the Hamming software ECC engine has been updated to become a proper and independent ECC engine" excuse makes no sense. If multiple chips just want a basic sw hamming helper, then they should have one. Not have to be forced to each write their own pointless wrapper like this.
These chip drivers just want 'ecc_sw_hamming_correct()' with the proper arguments, and it seems entirely wrong to duplicate the helper five times or whatever. There should just be a generic helper - the way there used to be.
In fact, I would generally strongly recommend that if there used to be a generic helper that different chip drivers used (ie the old rawnand_sw_hamming_correct()), then such a helper should be left alone and not change the semantics of it.
The new "proper independent ECC engine" that had new semantics should have been the one that got a new name, rather than breaking an old and existing helper function and then making the chip drivers pointlessly write their own new helper functions.
I've pulled this, but under protest. The patch honestly just looks like mindless duplication.
Linus
| |