lkml.org 
[lkml]   [2021]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: cdns3: Enable TDL_CHK only for OUT ep
From
Date
Hi Peter,

On 17/05/21 8:35 pm, Sanket Parmar wrote:
> ZLP gets stuck if TDL_CHK bit is set and TDL_FROM_TRB is used
> as TDL source for IN endpoints. To fix it, TDL_CHK is only
> enabled for OUT endpoints.
>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Reported-by: Aswath Govindraju <a-govindraju@ti.com>
> Signed-off-by: Sanket Parmar <sparmar@cadence.com>
> ---

May I know if this patch will be picked up as a bug fix for -rc.

Thanks,
Aswath

> drivers/usb/cdns3/cdns3-gadget.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index 105855a..f3c0276 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -2007,7 +2007,7 @@ static void cdns3_configure_dmult(struct cdns3_device *priv_dev,
> else
> mask = BIT(priv_ep->num);
>
> - if (priv_ep->type != USB_ENDPOINT_XFER_ISOC) {
> + if (priv_ep->type != USB_ENDPOINT_XFER_ISOC && !priv_ep->dir) {
> cdns3_set_register_bit(&regs->tdl_from_trb, mask);
> cdns3_set_register_bit(&regs->tdl_beh, mask);
> cdns3_set_register_bit(&regs->tdl_beh2, mask);
> @@ -2046,15 +2046,13 @@ int cdns3_ep_config(struct cdns3_endpoint *priv_ep, bool enable)
> case USB_ENDPOINT_XFER_INT:
> ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_INT);
>
> - if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) ||
> - priv_dev->dev_ver > DEV_VER_V2)
> + if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)
> ep_cfg |= EP_CFG_TDL_CHK;
> break;
> case USB_ENDPOINT_XFER_BULK:
> ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_BULK);
>
> - if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) ||
> - priv_dev->dev_ver > DEV_VER_V2)
> + if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)
> ep_cfg |= EP_CFG_TDL_CHK;
> break;
> default:
>

\
 
 \ /
  Last update: 2021-05-26 17:01    [W:0.130 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site