lkml.org 
[lkml]   [2021]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 4/4] gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support
Hi Steven,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on joel-aspeed/for-next]
[also build test ERROR on robh/for-next gpio/for-next v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Steven-Lee/ASPEED-sgpio-driver-enhancement/20210526-174912
base: https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git for-next
config: arc-randconfig-r023-20210526 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/72b31f2c47f6ab3ce9a7115dcc0dc01331bf45c0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Steven-Lee/ASPEED-sgpio-driver-enhancement/20210526-174912
git checkout 72b31f2c47f6ab3ce9a7115dcc0dc01331bf45c0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/gpio/gpio-aspeed-sgpio.c: In function 'aspeed_sgpio_get':
>> drivers/gpio/gpio-aspeed-sgpio.c:183:57: error: 'gpio' undeclared (first use in this function)
183 | const struct aspeed_sgpio_bank *bank = to_bank(offset, gpio->max_ngpios);
| ^~~~
drivers/gpio/gpio-aspeed-sgpio.c:183:57: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpio/gpio-aspeed-sgpio.c: In function 'sgpio_set_value':
drivers/gpio/gpio-aspeed-sgpio.c:201:57: error: 'gpio' undeclared (first use in this function)
201 | const struct aspeed_sgpio_bank *bank = to_bank(offset, gpio->max_ngpios);
| ^~~~


vim +/gpio +183 drivers/gpio/gpio-aspeed-sgpio.c

180
181 static int aspeed_sgpio_get(struct gpio_chip *gc, unsigned int offset)
182 {
> 183 const struct aspeed_sgpio_bank *bank = to_bank(offset, gpio->max_ngpios);
184 struct aspeed_sgpio *gpio = gpiochip_get_data(gc);
185 unsigned long flags;
186 enum aspeed_sgpio_reg reg;
187 int rc = 0;
188
189 spin_lock_irqsave(&gpio->lock, flags);
190
191 reg = aspeed_sgpio_is_input(offset, gpio->max_ngpios) ? reg_val : reg_rdata;
192 rc = !!(ioread32(bank_reg(gpio, bank, reg)) & GPIO_BIT(offset % gpio->max_ngpios));
193
194 spin_unlock_irqrestore(&gpio->lock, flags);
195
196 return rc;
197 }
198

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-05-26 16:05    [W:0.268 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site