lkml.org 
[lkml]   [2021]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RESEND PATCH v2 11/13] mfd: sec: Remove unused irq_base in platform data
    Date
    The 'irq_base' field of platform data structure is not assigned,
    therefore its default value of 0 has no impact and can be safely
    dropped.

    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    ---
    drivers/mfd/sec-core.c | 1 -
    drivers/mfd/sec-irq.c | 4 +---
    include/linux/mfd/samsung/core.h | 3 ---
    3 files changed, 1 insertion(+), 7 deletions(-)

    diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
    index 4c4db3171ce6..a9d4fbc51997 100644
    --- a/drivers/mfd/sec-core.c
    +++ b/drivers/mfd/sec-core.c
    @@ -337,7 +337,6 @@ static int sec_pmic_probe(struct i2c_client *i2c,
    }

    sec_pmic->device_type = (unsigned long)of_device_get_match_data(sec_pmic->dev);
    - sec_pmic->irq_base = pdata->irq_base;
    sec_pmic->wakeup = pdata->wakeup;
    sec_pmic->pdata = pdata;

    diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c
    index a98c5d165039..e473c2fb42d5 100644
    --- a/drivers/mfd/sec-irq.c
    +++ b/drivers/mfd/sec-irq.c
    @@ -444,7 +444,6 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
    if (!sec_pmic->irq) {
    dev_warn(sec_pmic->dev,
    "No interrupt specified, no interrupts\n");
    - sec_pmic->irq_base = 0;
    return 0;
    }

    @@ -482,8 +481,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
    ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,
    sec_pmic->irq,
    IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
    - sec_pmic->irq_base, sec_irq_chip,
    - &sec_pmic->irq_data);
    + 0, sec_irq_chip, &sec_pmic->irq_data);
    if (ret != 0) {
    dev_err(sec_pmic->dev, "Failed to register IRQ chip: %d\n", ret);
    return ret;
    diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/core.h
    index bfde1b7c6303..9864f13b7814 100644
    --- a/include/linux/mfd/samsung/core.h
    +++ b/include/linux/mfd/samsung/core.h
    @@ -67,7 +67,6 @@ struct sec_pmic_dev {
    struct i2c_client *i2c;

    unsigned long device_type;
    - int irq_base;
    int irq;
    struct regmap_irq_chip_data *irq_data;

    @@ -83,8 +82,6 @@ struct sec_platform_data {
    struct sec_opmode_data *opmode;
    int num_regulators;

    - int irq_base;
    -
    bool wakeup;
    bool buck_voltage_lock;

    --
    2.27.0
    \
     
     \ /
      Last update: 2021-05-26 14:52    [W:3.136 / U:4.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site