lkml.org 
[lkml]   [2021]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [External] [PATCH v2 1/4] slub: Restore slub_debug=- behavior
On Wed, May 26, 2021 at 10:56 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Passing slub_debug=- on the kernel commandline is supposed to disable
> slub debugging. This is especially useful with CONFIG_SLUB_DEBUG_ON
> where the default is to have slub debugging enabled in the build. Due to
> some code reorganization this behavior was dropped, but the code to make
> it work mostly stuck around. Restore the previous behavior by disabling
> the static key when we parse the commandline and see that we're trying
> to disable slub debugging.
>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Fixes: e17f1dfba37b ("mm, slub: extend slub_debug syntax for multiple blocks")

Is it caused by the commit ca0cab65ea2b ("mm, slub: introduce static
key for slub_debug()")?

> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> mm/slub.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 438fa8d4c970..2f53e8a9c28e 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1396,6 +1396,8 @@ static int __init setup_slub_debug(char *str)
> out:
> if (slub_debug != 0 || slub_debug_string)
> static_branch_enable(&slub_debug_enabled);
> + else
> + static_branch_disable(&slub_debug_enabled);
> if ((static_branch_unlikely(&init_on_alloc) ||
> static_branch_unlikely(&init_on_free)) &&
> (slub_debug & SLAB_POISON))
> --
> https://chromeos.dev
>

\
 
 \ /
  Last update: 2021-05-26 06:06    [W:0.146 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site