Messages in this thread |  | | Subject | Re: [PATCH RFC 4/7] kvm: x86: Add new ioctls for XSAVE extension | From | "Liu, Jing2" <> | Date | Wed, 26 May 2021 14:11:56 +0800 |
| |
On 5/25/2021 6:06 AM, Jim Mattson wrote: > On Sat, Feb 6, 2021 at 11:00 PM Jing Liu <jing2.liu@linux.intel.com> wrote: >> The static xstate buffer kvm_xsave contains the extended register >> states, but it is not enough for dynamic features with large state. >> >> Introduce a new capability called KVM_CAP_X86_XSAVE_EXTENSION to >> detect if hardware has XSAVE extension (XFD). Meanwhile, add two >> new ioctl interfaces to get/set the whole xstate using struct >> kvm_xsave_extension buffer containing both static and dynamic >> xfeatures. Reuse fill_xsave and load_xsave for both cases. >> >> Signed-off-by: Jing Liu <jing2.liu@linux.intel.com> >> --- >> +#define KVM_GET_XSAVE_EXTENSION _IOW(KVMIO, 0xa4, struct kvm_xsave_extension) >> +#define KVM_SET_XSAVE_EXTENSION _IOW(KVMIO, 0xa5, struct kvm_xsave_extension) > Isn't the convention to call these KVM_GET_XSAVE2 and KVM_SET_XSAVE2? > > Do you have any documentation to add to Documentation/virt/kvm/api.rst? Thanks for reviewing the patch. I'll change the name as convention and add documentation if new apis are needed.
BRs, Jing
|  |