lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 35/49] Revert "media: rcar_drif: fix a memory disclosure"
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    commit 3e465fc3846734e9489273d889f19cc17b4cf4bd upstream.

    This reverts commit d39083234c60519724c6ed59509a2129fd2aed41.

    Because of recent interactions with developers from @umn.edu, all
    commits from them have been recently re-reviewed to ensure if they were
    correct or not.

    Upon review, it was determined that this commit is not needed at all as
    the media core already prevents memory disclosure on this codepath, so
    just drop the extra memset happening here.

    Cc: Kangjie Lu <kjlu@umn.edu>
    Cc: Geert Uytterhoeven <geert+renesas@glider.be>
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    Fixes: d39083234c60 ("media: rcar_drif: fix a memory disclosure")
    Cc: stable <stable@vger.kernel.org>
    Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
    Link: https://lore.kernel.org/r/20210503115736.2104747-4-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/platform/rcar_drif.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/media/platform/rcar_drif.c
    +++ b/drivers/media/platform/rcar_drif.c
    @@ -912,7 +912,6 @@ static int rcar_drif_g_fmt_sdr_cap(struc
    {
    struct rcar_drif_sdr *sdr = video_drvdata(file);

    - memset(f->fmt.sdr.reserved, 0, sizeof(f->fmt.sdr.reserved));
    f->fmt.sdr.pixelformat = sdr->fmt->pixelformat;
    f->fmt.sdr.buffersize = sdr->fmt->buffersize;


    \
     
     \ /
      Last update: 2021-05-24 17:46    [W:4.107 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site