lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 09/37] Revert "ALSA: sb8: add a check for request_region"
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    commit 94f88309f201821073f57ae6005caefa61bf7b7e upstream.

    This reverts commit dcd0feac9bab901d5739de51b3f69840851f8919.

    Because of recent interactions with developers from @umn.edu, all
    commits from them have been recently re-reviewed to ensure if they were
    correct or not.

    Upon review, this commit was found to be incorrect for the reasons
    below, so it must be reverted. It will be fixed up "correctly" in a
    later kernel change.

    The original commit message for this change was incorrect as the code
    path can never result in a NULL dereference, alluding to the fact that
    whatever tool was used to "find this" is broken. It's just an optional
    resource reservation, so removing this check is fine.

    Cc: Kangjie Lu <kjlu@umn.edu>
    Acked-by: Takashi Iwai <tiwai@suse.de>
    Fixes: dcd0feac9bab ("ALSA: sb8: add a check for request_region")
    Cc: stable <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20210503115736.2104747-35-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/isa/sb/sb8.c | 4 ----
    1 file changed, 4 deletions(-)

    --- a/sound/isa/sb/sb8.c
    +++ b/sound/isa/sb/sb8.c
    @@ -111,10 +111,6 @@ static int snd_sb8_probe(struct device *

    /* block the 0x388 port to avoid PnP conflicts */
    acard->fm_res = request_region(0x388, 4, "SoundBlaster FM");
    - if (!acard->fm_res) {
    - err = -EBUSY;
    - goto _err;
    - }

    if (port[dev] != SNDRV_AUTO_PORT) {
    if ((err = snd_sbdsp_create(card, port[dev], irq[dev],

    \
     
     \ /
      Last update: 2021-05-24 17:44    [W:2.445 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site