lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 27/63] Revert "libertas: add checks for the return value of sysfs_create_group"
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    [ Upstream commit 46651077765c80a0d6f87f3469129a72e49ce91b ]

    This reverts commit 434256833d8eb988cb7f3b8a41699e2fe48d9332.

    Because of recent interactions with developers from @umn.edu, all
    commits from them have been recently re-reviewed to ensure if they were
    correct or not.

    Upon review, this commit was found to be incorrect for the reasons
    below, so it must be reverted. It will be fixed up "correctly" in a
    later kernel change.

    The original commit was incorrect, the error needs to be propagated back
    to the caller AND if the second group call fails, the first needs to be
    removed. There are much better ways to solve this, the driver should
    NOT be calling sysfs_create_group() on its own as it is racing userspace
    and loosing.

    Cc: Kangjie Lu <kjlu@umn.edu>
    Cc: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20210503115736.2104747-53-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/marvell/libertas/mesh.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
    index f5b78257d551..c611e6668b21 100644
    --- a/drivers/net/wireless/marvell/libertas/mesh.c
    +++ b/drivers/net/wireless/marvell/libertas/mesh.c
    @@ -805,12 +805,7 @@ static void lbs_persist_config_init(struct net_device *dev)
    {
    int ret;
    ret = sysfs_create_group(&(dev->dev.kobj), &boot_opts_group);
    - if (ret)
    - pr_err("failed to create boot_opts_group.\n");
    -
    ret = sysfs_create_group(&(dev->dev.kobj), &mesh_ie_group);
    - if (ret)
    - pr_err("failed to create mesh_ie_group.\n");
    }

    static void lbs_persist_config_remove(struct net_device *dev)
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-05-24 16:49    [W:3.287 / U:1.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site