lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] staging: rtl8723bs: fix indents in rtw_wlan_util.c
Date
This patch series aims to solve all indent related issues for the file
core/rtw_wlan_util.c.

The first two patches fix the follwing issues reported by checkpatch.pl:

WARNING: Too many leading tabs - consider code refactoring
#887: FILE: rtw_wlan_util.c:887:
+ if ((edca[j] >> 16) > (edca[i] >> 16))

WARNING: Too many leading tabs - consider code refactoring
#1528: FILE: rtw_wlan_util.c:1528:
+ if (pIE->data[5] & RT_HT_CAP_USE_92SE)

WARNING: Too many leading tabs - consider code refactoring
#1536: FILE: rtw_wlan_util.c:1536:
+ if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_BCUT)

WARNING: Too many leading tabs - consider code refactoring
#1539: FILE: rtw_wlan_util.c:1539:
+ if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_CCUT)


The last patch fixes the follwing issues reported by checkpatch.pl:

WARNING: suspect code indent for conditional statements (8, 24)
#1257: FILE: rtw_wlan_util.c:1257:
+ if (p && len > 0) {
+ pht_cap = (struct ieee80211_ht_cap *)(p + 2);

WARNING: suspect code indent for conditional statements (8, 24)
#1260: FILE: rtw_wlan_util.c:1260:
+ } else {
+ ht_cap_info = 0;

WARNING: suspect code indent for conditional statements (8, 24)
#1265: FILE: rtw_wlan_util.c:1265:
+ if (p && len > 0) {
+ pht_info = (struct HT_info_element *)(p + 2);

WARNING: suspect code indent for conditional statements (8, 24)
#1268: FILE: rtw_wlan_util.c:1268:
+ } else {
+ ht_info_infos_0 = 0;

WARNING: suspect code indent for conditional statements (8, 24)
#1271: FILE: rtw_wlan_util.c:1271:
+ if (ht_cap_info != cur_network->BcnInfo.ht_cap_info ||
[...]
+ {

WARNING: suspect code indent for conditional statements (8, 24)
#1284: FILE: rtw_wlan_util.c:1284:
+ if (p) {
+ bcn_channel = *(p + 2);

WARNING: suspect code indent for conditional statements (8, 24)
#1295: FILE: rtw_wlan_util.c:1295:
+ if (bcn_channel != Adapter->mlmeextpriv.cur_channel)
+ goto _mismatch;

Shreyansh Chouhan (3):
staging: rtl8723bs: refactor to reduce indents
staging: rtl8723bs: remove unnecessary braces from conditionals
staging: rtl8723bs: fix suspect indents

.../staging/rtl8723bs/core/rtw_wlan_util.c | 161 +++++++++---------
1 file changed, 82 insertions(+), 79 deletions(-)

--
2.31.1

\
 
 \ /
  Last update: 2021-05-24 15:51    [W:0.061 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site