Messages in this thread | | | Date | Mon, 24 May 2021 15:39:04 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec |
| |
Hi,
On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > Hi, > > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place, > it's missing a few controls to be able to provide HBR passthrough. This series > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > controller driver. > > One thing that felt a bit weird is that even though > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif > mentions that the iec958 mask control should be a mixer control and the > default control should be a PCM one, it feels a bit weird to have two different > control type for two controls so similar, and other drivers are pretty > inconsistent with this. Should we update the documentation?
Any comments on this series? Thanks! Maxime [unhandled content-type:application/pgp-signature] | |