lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] mfd: syscon: Fix leak of syscon name
    Date
    regmap_init_mmio duplicate the name and never free the provided name in
    the sysconf_config. Always free the name instead of freeing only on
    error to fix error from kmemleak generated by any syscon user.

    Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
    ---
    drivers/mfd/syscon.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
    index c6f139b2e0c0..765c0210cb52 100644
    --- a/drivers/mfd/syscon.c
    +++ b/drivers/mfd/syscon.c
    @@ -108,6 +108,7 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk)
    syscon_config.max_register = resource_size(&res) - reg_io_width;

    regmap = regmap_init_mmio(NULL, base, &syscon_config);
    + kfree(syscon_config.name);
    if (IS_ERR(regmap)) {
    pr_err("regmap init failed\n");
    ret = PTR_ERR(regmap);
    @@ -144,7 +145,6 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk)
    regmap_exit(regmap);
    err_regmap:
    iounmap(base);
    - kfree(syscon_config.name);
    err_map:
    kfree(syscon);
    return ERR_PTR(ret);
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-05-25 02:15    [W:4.183 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site