lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] crypto: algboss - Replaced simple_strtol() with kstrtouint()
On Mon, May 24, 2021 at 08:08:34PM +0800, Liu Shixin wrote:
> The simple_strtol() function is deprecated in some situation since
> it does not check for the range overflow. Use kstrtouint() instead.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> crypto/algboss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/crypto/algboss.c b/crypto/algboss.c
> index 5ebccbd6b74e..64bb8dab9584 100644
> --- a/crypto/algboss.c
> +++ b/crypto/algboss.c
> @@ -140,8 +140,8 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
> param->attrs[i].nu32.attr.rta_len =
> sizeof(param->attrs[i].nu32);
> param->attrs[i].nu32.attr.rta_type = CRYPTOA_U32;
> - param->attrs[i].nu32.data.num =
> - simple_strtol(name, NULL, 0);
> + if (unlikely(kstrtouint(name, 0, &param->attrs[i].nu32.data.num)))
> + goto err_free_param;

It would be better to just remove all the code related to CRYPTOA_U32 and
crypto_attr_u32, as it is never used.

- Eric

\
 
 \ /
  Last update: 2021-05-24 23:58    [W:0.404 / U:1.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site