Messages in this thread | | | Date | Mon, 24 May 2021 18:24:33 +0200 | From | Ralf Schlatterbeck <> | Subject | Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug |
| |
On Mon, May 24, 2021 at 01:33:01PM +0100, Andre Przywara wrote: > - Single patch set series don't bother to have a "1/1" after the > "PATCH". > - You are expected to increase the version number when you send a new > version, to show that *this* is better than the previous post and > this version should be merged. Otherwise the maintainer might pick > the wrong version. "git format-patch -v2" and "git send-email" will > automatically take care of this.
OK I'll keep that in mind.
> Please keep in mind that text after the dashes doesn't make it in it > repo, so this information would be lost there. Also, in general links in > commit messages are somewhat frowned upon, since they tend to 404 > sooner or later. So ideally you can put a condensed version of your > findings into the commit message? Don't worry if it grows long, it is > not uncommon to have a 2 page commit message for a one-liner patch.
This was intentional, the commit message is only the upper part. The Links were meant to give a lot of details why the patch fixes something. I think the commit message already explains the condensed findings. I've put this additional explanation text after the '---' to not need an additional Patch 0/1 email ;-)
Thanks! Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting www: www.runtux.com Reichergasse 131, A-3411 Weidling email: office@runtux.com
| |