lkml.org 
[lkml]   [2021]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 2/5] USB: misc: Add onboard_usb_hub driver
On Wed, May 19, 2021 at 04:07:17PM -0700, Matthias Kaehlcke wrote:
> On Wed, May 19, 2021 at 10:43:56AM -0400, Alan Stern wrote:
> > On Tue, May 18, 2021 at 02:40:47PM -0700, Matthias Kaehlcke wrote:
> > >
> > > Could you also have a look at "[4/5] usb: host: xhci-plat:
> > > Create platform device for onboard hubs in probe()"
> > > (https://lore.kernel.org/patchwork/patch/1425453/)? It's a
> > > relatively short patch that creates the platform device for
> > > the driver from xhci-plat as you suggested in the v4
> > > discussion.
> >
> > I'm not the maintainer for xhci-related drivers.
> >
> > However, there is at least one thing about this patch which looks
> > suspicious: Adding the onboard_hub_dev pointer to struct usb_hcd instead
> > of to struct xhci_plat_priv, where it would make a lot more sense.
>
> I can move it to struct usb_hcd if that's preferred

Thinko: The patch already has it in struct usb_hcd. I suggested moving
it to struct xhci_plat_priv.

Alan Stern

\
 
 \ /
  Last update: 2021-05-20 04:07    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog