Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH v2] b43legacy: don't save dentries for debugfs | Date | Tue, 18 May 2021 20:48:39 +0300 |
| |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> There is no need to keep around the dentry pointers for the debugfs > files as they will all be automatically removed when the subdir is > removed. So save the space and logic involved in keeping them around by > just getting rid of them entirely. > > By doing this change, we remove one of the last in-kernel user that was > storing the result of debugfs_create_bool(), so that api can be cleaned > up. > > Cc: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: linux-wireless@vger.kernel.org > Cc: b43-dev@lists.infradead.org > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > .../net/wireless/broadcom/b43legacy/debugfs.c | 29 ++++--------------- > .../net/wireless/broadcom/b43legacy/debugfs.h | 3 -- > 2 files changed, 5 insertions(+), 27 deletions(-) > > Note, I can take this through my debugfs tree if wanted, that way I can > clean up the debugfs_create_bool() api at the same time. Otherwise it's > fine, I can wait until next -rc1 for that to happen.
Acked-by: Kalle Valo <kvalo@codeaurora.org>
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |