lkml.org 
[lkml]   [2021]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC net-next af_unix v1 1/1] net:af_unix: Allow unix sockets to raise SIGURG
On Tue, May 18, 2021 at 12:43:43AM -0700, Rao Shoaib wrote:
> From: Rao Shoaib <rao.shoaib@oracle.com>
>
> TCP sockets allow SIGURG to be sent to the process holding the other
> end of the socket. Extend Unix sockets to have the same ability.
>
> The API is the same in that the sender uses sendmsg() with MSG_OOB to
> raise SIGURG. Unix sockets behave in the same way as TCP sockets with
> SO_OOBINLINE set.
>
> SIGURG is ignored by default, so applications which do not know about this
> feature will be unaffected. In addition to installing a SIGURG handler,
> the receiving application must call F_SETOWN or F_SETOWN_EX to indicate
> which process or thread should receive the signal.
>
> Signed-off-by: Rao Shoaib <rao.shoaib@oracle.com>
> Signed-off-by: Matthew Wilcox <matthew.wilcox@oracle.com>

Please don't forge my Signed-off-by. With that line deleted,

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

> ---
> net/unix/af_unix.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 5a31307ceb76..c8400c002882 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -1838,8 +1838,6 @@ static int unix_stream_sendmsg(struct socket *sock, struct msghdr *msg,
> return err;
>
> err = -EOPNOTSUPP;
> - if (msg->msg_flags&MSG_OOB)
> - goto out_err;
>
> if (msg->msg_namelen) {
> err = sk->sk_state == TCP_ESTABLISHED ? -EISCONN : -EOPNOTSUPP;
> @@ -1904,6 +1902,9 @@ static int unix_stream_sendmsg(struct socket *sock, struct msghdr *msg,
> sent += size;
> }
>
> + if (msg->msg_flags & MSG_OOB)
> + sk_send_sigurg(other);
> +
> scm_destroy(&scm);
>
> return sent;
> --
> 2.31.1
>

\
 
 \ /
  Last update: 2021-05-18 18:57    [W:0.748 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site