Messages in this thread | | | Date | Tue, 18 May 2021 16:20:12 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH] kcsan: fix debugfs initcall return type |
| |
On Fri, May 14, 2021 at 05:55:50PM -0700, Paul E. McKenney wrote: > On Sat, May 15, 2021 at 01:01:31AM +0200, Marco Elver wrote: > > On Fri, May 14, 2021 at 11:16PM +0200, Arnd Bergmann wrote: > > > On Fri, May 14, 2021 at 10:18 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > On Fri, May 14, 2021 at 01:11:05PM -0700, Nathan Chancellor wrote: > > > > > > > > You can see my response to Marco here: > > > > > > > > > > https://lore.kernel.org/r/ad7fa126-f371-5a24-1d80-27fe8f655b05@kernel.org/ > > > > > > > > > > Maybe some improved wording might look like > > > > > > > > > > clang with CONFIG_LTO_CLANG points out that an initcall function should > > > > > return an 'int' due to the changes made to the initcall macros in commit > > > > > 3578ad11f3fb ("init: lto: fix PREL32 relocations"): > > > > > > > > OK, so the naive reading was correct, thank you! > > > > > > > > > ... > > > > > > > > > > Arnd, do you have any objections? > > > > > > > > In the meantime, here is what I have. Please let me know of any needed > > > > updates. > > > > > > > > > > Looks good to me, thanks for the improvements! > > > > FWIW, this prompted me to see if I can convince the compiler to complain > > in all configs. The below is what I came up with and will send once the > > fix here has landed. Need to check a few other config+arch combinations > > (allyesconfig with gcc on x86_64 is good). > > Cool! > > If I have not sent the pull request for Arnd's fix by Wednesday, please > remind me.
Except that I was slow getting Miguel Ojeda's Reviewed-by applied. I need to wait for -next to incorporate this change (hopefully by tomorrow, Pacific Time), and then test this. With luck, I will send this Thursday, Pacific Time.
Thanx, Paul
| |