lkml.org 
[lkml]   [2021]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time
    On Sat, May 15, 2021 at 11:34:49PM -0700, Nathan Chancellor wrote:
    > This should work I think:

    compiled well with clang-10.0.1, clang-11.0.0,
    and gcc-10.2.0 with x86_64 default config.

    is the condition CONFIG_CLANG_VERSION > 110000,
    not including 110000 it self?

    > diff --git a/include/linux/slab.h b/include/linux/slab.h
    > index 9d316aac0aba..1b653266f2aa 100644
    > --- a/include/linux/slab.h
    > +++ b/include/linux/slab.h
    > @@ -413,7 +413,7 @@ static __always_inline unsigned int __kmalloc_index(size_t size,
    > if (size <= 16 * 1024 * 1024) return 24;
    > if (size <= 32 * 1024 * 1024) return 25;
    >
    > - if (size_is_constant)
    > + if ((IS_ENABLED(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION > 110000) && size_is_constant)
    > BUILD_BUG_ON_MSG(1, "unexpected size in kmalloc_index()");
    > else
    > BUG();

    \
     
     \ /
      Last update: 2021-05-18 02:40    [W:4.231 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site